Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2395)

Unified Diff: chrome/renderer/extensions/app_bindings_core.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/app_bindings_core.cc
diff --git a/chrome/renderer/extensions/app_bindings_core.cc b/chrome/renderer/extensions/app_bindings_core.cc
index 45f99e11aacc40c9889f7d7fccb6663f361a173d..be5d7d2e3a7442eb77ae490a9a59f2ce068f2922 100644
--- a/chrome/renderer/extensions/app_bindings_core.cc
+++ b/chrome/renderer/extensions/app_bindings_core.cc
@@ -54,10 +54,8 @@ v8::Local<v8::Value> AppBindingsCore::GetDetails(
std::unique_ptr<base::DictionaryValue> manifest_copy =
extension->manifest()->value()->CreateDeepCopy();
manifest_copy->SetString("id", extension->id());
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- return converter->ToV8Value(manifest_copy.get(),
- script_context->v8_context());
+ return content::V8ValueConverter::Create()->ToV8Value(
+ manifest_copy.get(), script_context->v8_context());
}
void AppBindingsCore::GetInstallState(ScriptContext* script_context,
« no previous file with comments | « no previous file | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698