Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: extensions/renderer/send_request_natives.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/script_injection.cc ('k') | extensions/renderer/test_features_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/send_request_natives.cc
diff --git a/extensions/renderer/send_request_natives.cc b/extensions/renderer/send_request_natives.cc
index 5824bc0ea2b998445db8c2b3635977dda6ecc8d9..a305b6a94c862011290591209382fd4f0c3b9a61 100644
--- a/extensions/renderer/send_request_natives.cc
+++ b/extensions/renderer/send_request_natives.cc
@@ -13,8 +13,6 @@
#include "extensions/renderer/request_sender.h"
#include "extensions/renderer/script_context.h"
-using content::V8ValueConverter;
-
namespace extensions {
SendRequestNatives::SendRequestNatives(RequestSender* request_sender,
@@ -42,7 +40,8 @@ void SendRequestNatives::StartRequest(
int request_id = request_sender_->GetNextRequestId();
args.GetReturnValue().Set(static_cast<int32_t>(request_id));
- std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+ std::unique_ptr<content::V8ValueConverter> converter =
+ content::V8ValueConverter::Create();
// See http://crbug.com/149880. The context menus APIs relies on this, but
// we shouldn't really be doing it (e.g. for the sake of the storage API).
« no previous file with comments | « extensions/renderer/script_injection.cc ('k') | extensions/renderer/test_features_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698