Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: extensions/renderer/messaging_bindings.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/i18n_custom_bindings.cc ('k') | extensions/renderer/runtime_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/messaging_bindings.cc
diff --git a/extensions/renderer/messaging_bindings.cc b/extensions/renderer/messaging_bindings.cc
index a15870b9dcc589e450c907aa24ef11d880b4789d..5b279b3037a685905ae5148b09dce4489f6858da 100644
--- a/extensions/renderer/messaging_bindings.cc
+++ b/extensions/renderer/messaging_bindings.cc
@@ -128,9 +128,8 @@ void DispatchOnConnectToScriptContext(
if (extension) {
if (!source->tab.empty() && !extension->is_platform_app()) {
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- tab = converter->ToV8Value(&source->tab, script_context->v8_context());
+ tab = content::V8ValueConverter::Create()->ToV8Value(
+ &source->tab, script_context->v8_context());
}
ExternallyConnectableInfo* externally_connectable =
« no previous file with comments | « extensions/renderer/i18n_custom_bindings.cc ('k') | extensions/renderer/runtime_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698