Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: extensions/renderer/api_signature.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_request_handler.cc ('k') | extensions/renderer/argument_spec.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_signature.cc
diff --git a/extensions/renderer/api_signature.cc b/extensions/renderer/api_signature.cc
index b2eb02fc73d7c1699298d63c8eb6550dca7abad9..c07705fba852e7655269de065c96896698c5fc35 100644
--- a/extensions/renderer/api_signature.cc
+++ b/extensions/renderer/api_signature.cc
@@ -327,8 +327,8 @@ bool APISignature::ConvertArgumentsIgnoringSchema(
}
auto json = base::MakeUnique<base::ListValue>();
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
+ std::unique_ptr<content::V8ValueConverter> converter =
+ content::V8ValueConverter::Create();
converter->SetFunctionAllowed(true);
for (size_t i = 0; i < size; ++i) {
std::unique_ptr<base::Value> converted =
« no previous file with comments | « extensions/renderer/api_request_handler.cc ('k') | extensions/renderer/argument_spec.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698