Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Rewrite was automatically done via clang.) BUG=670615 Review-Url: https://codereview.chromium.org/2836093004 Cr-Commit-Position: refs/heads/master@{#467035} Committed: https://chromium.googlesource.com/chromium/src/+/a8416d28ba0e17d3b6cc8b1e328bf1bea8210891

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -150 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp View 1 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp View 1 12 chunks +17 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h View 1 chunk +1 line, -38 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 1 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DictionaryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp View 5 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (15 generated)
jbroman
3 years, 8 months ago (2017-04-25 02:44:19 UTC) #9
Yuki
LGTM.
3 years, 8 months ago (2017-04-25 09:21:10 UTC) #13
haraken
LGTM. Thanks for doing this!
3 years, 8 months ago (2017-04-25 09:26:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836093004/40001
3 years, 8 months ago (2017-04-25 15:18:07 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 17:27:29 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a8416d28ba0e17d3b6cc8b1e328b...

Powered by Google App Engine
This is Rietveld 408576698