third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

index acd06af145e6bba2298e419f941ef8f4efeb1835..e56c2f03d6b7bd59788a2be792167943108c221d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

@@ -107,10 +107,12 @@ void V8MessageEvent::initMessageEventMethodCustom(

TOSTRING_VOID(V8StringResource<>, type_arg, info[0]);

bool can_bubble_arg = false;

bool cancelable_arg = false;

- if (!V8Call(info[1]->BooleanValue(info.GetIsolate()->GetCurrentContext()),

- can_bubble_arg) ||

- !V8Call(info[2]->BooleanValue(info.GetIsolate()->GetCurrentContext()),

- cancelable_arg))

+ if (!info[1]

+ ->BooleanValue(info.GetIsolate()->GetCurrentContext())

+ .To(&can_bubble_arg) ||

+ !info[2]

+ ->BooleanValue(info.GetIsolate()->GetCurrentContext())

+ .To(&cancelable_arg))

return;

v8::Local<v8::Value> data_arg = info[3];

TOSTRING_VOID(V8StringResource<>, origin_arg, info[4]);