Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp b/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp
index 24fc1d1b01e25006866f1b18676b2aa5f3ff23c5..731564078c0e9f75c4e4e15d6146b2310d38b68c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp
@@ -102,9 +102,9 @@ void V8HTMLConstructor::HtmlConstructor(
// 6. Let prototype be Get(NewTarget, "prototype"). Rethrow any exceptions.
v8::Local<v8::Value> prototype;
v8::Local<v8::String> prototype_string = V8AtomicString(isolate, "prototype");
- if (!V8Call(new_target.As<v8::Object>()->Get(script_state->GetContext(),
- prototype_string),
- prototype)) {
+ if (!new_target.As<v8::Object>()
+ ->Get(script_state->GetContext(), prototype_string)
+ .ToLocal(&prototype)) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698