Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index 341a948c3c81dd8eaea6658a263b2f0de93148e9..8f03da4fe08d79e3a69f87743a86a5ce465c4aad 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -128,15 +128,14 @@ v8::Local<v8::Value> ScriptController::ExecuteScriptAndReturnValue(
try_catch.SetVerbose(true);
v8::Local<v8::Script> script;
- if (!V8Call(
- V8ScriptRunner::CompileScript(
- source, GetIsolate(), access_control_status, v8_cache_options),
- script, try_catch))
+ if (!V8ScriptRunner::CompileScript(source, GetIsolate(),
+ access_control_status, v8_cache_options)
+ .ToLocal(&script))
return result;
- if (!V8Call(V8ScriptRunner::RunCompiledScript(GetIsolate(), script,
- GetFrame()->GetDocument()),
- result, try_catch))
+ if (!V8ScriptRunner::RunCompiledScript(GetIsolate(), script,
+ GetFrame()->GetDocument())
+ .ToLocal(&result))
return result;
}

Powered by Google App Engine
This is Rietveld 408576698