third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

index 2dfe5d1557ed18dfda8d7d1364d9b2721ed046d1..70acbf3429e561aede0150144d32049d03fcaae9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

@@ -64,7 +64,7 @@ CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,

if (!dictionary.Get(key, v8_value))

return false;

- return V8Call(v8_value->BooleanValue(dictionary.V8Context()), value);

+ return v8_value->BooleanValue(dictionary.V8Context()).To(&value);

}

template <>

@@ -75,7 +75,7 @@ CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,

if (!dictionary.Get(key, v8_value))

return false;

- return V8Call(v8_value->Int32Value(dictionary.V8Context()), value);

+ return v8_value->Int32Value(dictionary.V8Context()).To(&value);

}

template <>

@@ -90,7 +90,7 @@ CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,

}

has_value = true;

- return V8Call(v8_value->NumberValue(dictionary.V8Context()), value);

+ return v8_value->NumberValue(dictionary.V8Context()).To(&value);

}

template <>

@@ -171,7 +171,7 @@ bool DictionaryHelper::Get(const Dictionary& dictionary,

return false;

int64_t int64_value;

- if (!V8Call(v8_value->IntegerValue(dictionary.V8Context()), int64_value))

+ if (!v8_value->IntegerValue(dictionary.V8Context()).To(&int64_value))

return false;

value = int64_value;

return true;

@@ -186,7 +186,7 @@ bool DictionaryHelper::Get(const Dictionary& dictionary,

return false;

double double_value;

- if (!V8Call(v8_value->NumberValue(dictionary.V8Context()), double_value))

+ if (!v8_value->NumberValue(dictionary.V8Context()).To(&double_value))

return false;

doubleToInteger(double_value, value);

return true;