third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

index 2391154f59477b3ae80ebd92a1080568e4e6d453..fc69c2eac808c6e669907d5e615d051fe12cf1e0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

@@ -123,8 +123,7 @@ unsigned V8NodeFilterCondition::AcceptNode(

DCHECK(!result.IsEmpty());

uint32_t uint32_value;

- if (!V8Call(result->Uint32Value(script_state_->GetContext()), uint32_value,

- exception_catcher)) {

+ if (!result->Uint32Value(script_state_->GetContext()).To(&uint32_value)) {

exception_state.RethrowV8Exception(exception_catcher.Exception());

return NodeFilter::kFilterReject;

}