Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp
diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp b/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp
index 8e891382b5a665b0f9fed8f66a594cc6fdde13e1..7e7848954cdf6388708f91346c887f5f6d34ce19 100644
--- a/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp
+++ b/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp
@@ -54,9 +54,9 @@ class Iteration final : public GarbageCollectedFinalized<Iteration> {
v8::Local<v8::Value> value;
v8::Local<v8::Value> item = v.V8Value();
if (!item->IsObject() ||
- !V8Call(V8UnpackIteratorResult(v.GetScriptState(),
- item.As<v8::Object>(), &is_done_),
- value)) {
+ !V8UnpackIteratorResult(v.GetScriptState(), item.As<v8::Object>(),
+ &is_done_)
+ .ToLocal(&value)) {
is_valid_ = false;
return;
}
@@ -134,13 +134,13 @@ ScriptValue Eval(V8TestingScope* scope, const char* s) {
v8::Local<v8::Script> script;
v8::MicrotasksScope microtasks(scope->GetIsolate(),
v8::MicrotasksScope::kDoNotRunMicrotasks);
- if (!V8Call(v8::String::NewFromUtf8(scope->GetIsolate(), s,
- v8::NewStringType::kNormal),
- source)) {
+ if (!v8::String::NewFromUtf8(scope->GetIsolate(), s,
+ v8::NewStringType::kNormal)
+ .ToLocal(&source)) {
ADD_FAILURE();
return ScriptValue();
}
- if (!V8Call(v8::Script::Compile(scope->GetContext(), source), script)) {
+ if (!v8::Script::Compile(scope->GetContext(), source).ToLocal(&script)) {
ADD_FAILURE() << "Compilation fails";
return ScriptValue();
}

Powered by Google App Engine
This is Rietveld 408576698