Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
diff --git a/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp b/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
index 2913e3a296729346a3a72338527beb1309838c58..c746a6a63f4304e75adc9971f2558c20b8b337be 100644
--- a/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
+++ b/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
@@ -182,8 +182,8 @@ void CryptoResultImpl::CompleteWithJson(const char* utf8_data,
v8::TryCatch exception_catcher(script_state->GetIsolate());
v8::Local<v8::Value> json_dictionary;
- if (V8Call(v8::JSON::Parse(script_state->GetIsolate(), json_string),
- json_dictionary, exception_catcher))
+ if (v8::JSON::Parse(script_state->GetIsolate(), json_string)
+ .ToLocal(&json_dictionary))
resolver_->Resolve(json_dictionary);
else
resolver_->Reject(exception_catcher.Exception());

Powered by Google App Engine
This is Rietveld 408576698