Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
index 1d5f20aa2a9f0fd30d80cd5c05881938140d5998..2c84b4471225a6a1ad7f865f871f0345859dc474 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
@@ -221,7 +221,7 @@ static IDBKey* CreateIDBKeyFromValue(v8::Isolate* isolate,
if (!V8CallBoolean(array->HasOwnProperty(context, i)))
return nullptr;
v8::Local<v8::Value> item;
- if (!V8Call(array->Get(context, i), item, block)) {
+ if (!array->Get(context, i).ToLocal(&item)) {
exception_state.RethrowV8Exception(block.Exception());
return nullptr;
}
@@ -343,7 +343,7 @@ static IDBKey* CreateIDBKeyFromValueAndKeyPath(
v8::Local<v8::String> key = V8String(isolate, element);
if (!V8CallBoolean(object->HasOwnProperty(context, key)))
return nullptr;
- if (!V8Call(object->Get(context, key), v8_value, block)) {
+ if (!object->Get(context, key).ToLocal(&v8_value)) {
exception_state.RethrowV8Exception(block.Exception());
return nullptr;
}
@@ -522,7 +522,7 @@ bool InjectV8KeyIntoV8Value(v8::Isolate* isolate,
v8::Local<v8::Object> object = value.As<v8::Object>();
v8::Local<v8::String> property = V8String(isolate, key_path_element);
bool has_own_property;
- if (!V8Call(object->HasOwnProperty(context, property), has_own_property))
+ if (!object->HasOwnProperty(context, property).To(&has_own_property))
return false;
if (has_own_property) {
if (!object->Get(context, property).ToLocal(&value))
@@ -585,7 +585,7 @@ bool CanInjectIDBKeyIntoScriptValue(v8::Isolate* isolate,
// If the value lacks an "own" property, it can be added - either as
// an intermediate object or as the final value.
bool has_own_property;
- if (!V8Call(object->HasOwnProperty(context, property), has_own_property))
+ if (!object->HasOwnProperty(context, property).To(&has_own_property))
return false;
if (!has_own_property)
return true;

Powered by Google App Engine
This is Rietveld 408576698