third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

index bd49ff3d4ced91b8a91776a35a55147c95398043..f500bfe0769cee26d684870260e1cc87936825a9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

@@ -257,10 +257,10 @@ ScriptValue WorkerOrWorkletScriptController::Evaluate(

v8::Local<v8::Script> compiled_script;

v8::MaybeLocal<v8::Value> maybe_result;

- if (V8Call(V8ScriptRunner::CompileScript(

- script, file_name, String(), script_start_position, isolate_,

- cache_handler, kSharableCrossOrigin, v8_cache_options),

- compiled_script, block))

+ if (V8ScriptRunner::CompileScript(

+ script, file_name, String(), script_start_position, isolate_,

+ cache_handler, kSharableCrossOrigin, v8_cache_options)

+ .ToLocal(&compiled_script))

maybe_result = V8ScriptRunner::RunCompiledScript(isolate_, compiled_script,

global_scope_);