third_party/WebKit/Source/core/testing/DictionaryTest.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

diff --git a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

index f85dd44ffd9b25aa760621b5aba2b9a8e6434117..2d7097f06b41d89cca04d4e00b8770316816fb9a 100644

--- a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

+++ b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

@@ -190,7 +190,7 @@ String DictionaryTest::stringFromIterable(

result.Append(',');

v8::Local<v8::Value> value;

- if (V8Call(iterator.GetValue(), value))

+ if (iterator.GetValue().ToLocal(&value))

result.Append(ToCoreString(value->ToString()));

}