Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h b/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h
index d58ff2653ba9cf4f6667046b5ce3473f3fcebbbb..215eca8768e236e99780ec726ba8825f96412601 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h
@@ -59,47 +59,10 @@ namespace blink {
? alloca(value.As<v8::ArrayBufferView>()->ByteLength()) \
: nullptr)
-// DEPRECATED: These v8Call macros are deprecated.
-// Use To/ToLocal/ToChecked/ToLocalChecked instead.
-// TODO(haraken): Remove these macros.
-template <typename T>
-inline bool V8Call(v8::Maybe<T> maybe, T& out_variable) {
- if (maybe.IsNothing())
- return false;
- out_variable = maybe.FromJust();
- return true;
-}
-
// DEPRECATED
inline bool V8CallBoolean(v8::Maybe<bool> maybe) {
bool result;
- return V8Call(maybe, result) && result;
-}
-
-// DEPRECATED
-template <typename T>
-inline bool V8Call(v8::Maybe<T> maybe,
- T& out_variable,
- v8::TryCatch& try_catch) {
- bool success = V8Call(maybe, out_variable);
- DCHECK(success || try_catch.HasCaught());
- return success;
-}
-
-// DEPRECATED
-template <typename T>
-inline bool V8Call(v8::MaybeLocal<T> maybe_local, v8::Local<T>& out_variable) {
- return maybe_local.ToLocal(&out_variable);
-}
-
-// DEPRECATED
-template <typename T>
-inline bool V8Call(v8::MaybeLocal<T> maybe_local,
- v8::Local<T>& out_variable,
- v8::TryCatch& try_catch) {
- bool success = maybe_local.ToLocal(&out_variable);
- DCHECK(success || try_catch.HasCaught());
- return success;
+ return maybe.To(&result) && result;
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698