Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
index 7280f32446e4caaf5908536d71d314aff6ddaebc..6c0d0c974fc58673df34a9cd86847ae6dbf41918 100644
--- a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
@@ -95,10 +95,8 @@ std::unique_ptr<SourceLocation> SourceLocation::FromMessage(
int line_number = 0;
int column_number = 0;
- if (V8Call(message->GetLineNumber(isolate->GetCurrentContext()),
- line_number) &&
- V8Call(message->GetStartColumn(isolate->GetCurrentContext()),
- column_number))
+ if (message->GetLineNumber(isolate->GetCurrentContext()).To(&line_number) &&
+ message->GetStartColumn(isolate->GetCurrentContext()).To(&column_number))
++column_number;
if ((!script_id || !line_number) && stack_trace && !stack_trace->isEmpty())

Powered by Google App Engine
This is Rietveld 408576698