Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp b/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp
index 0aa7df220b40984ea621e1803e696a4a8768a926..a95c695a8eb94240f59a8ac51d0c3fb39be1aba4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp
@@ -88,7 +88,7 @@ bool DictionaryIterator::ValueAsDictionary(Dictionary& result,
DCHECK(!done_);
v8::Local<v8::Value> value;
- if (!V8Call(value_, value) || !value->IsObject())
+ if (!value_.ToLocal(&value) || !value->IsObject())
return false;
result = Dictionary(isolate_, value, exception_state);
@@ -100,7 +100,7 @@ bool DictionaryIterator::ValueAsString(String& result) {
DCHECK(!done_);
v8::Local<v8::Value> value;
- if (!V8Call(value_, value))
+ if (!value_.ToLocal(&value))
return false;
V8StringResource<> string_value(value);

Powered by Google App Engine
This is Rietveld 408576698