third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

index ffffdab73748bb3d6c904f54b3e0b48dd7f3ff3d..fbc6d6edfe2ca1b81eaee354c9f5c5e7a5c3a95f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

@@ -99,7 +99,7 @@ static bool PopulateContextMenuItems(v8::Isolate* isolate,

menu.AppendItem(item);

} else {

int32_t int32_id;

- if (!V8Call(id->Int32Value(context), int32_id))

+ if (!id->Int32Value(context).To(&int32_id))

return false;

ContextMenuAction typed_id = static_cast<ContextMenuAction>(

kContextMenuItemBaseCustomTag + int32_id);