Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp
index 57712318bfd2d640e8098e70ffb9292e33af8691..98b1d22b60852e47b9d71abfad7d7e33b76f22c0 100644
--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp
@@ -58,14 +58,13 @@ class ReadableStreamBytesConsumerTest : public ::testing::Test {
v8::Local<v8::Script> script;
v8::MicrotasksScope microtasks(GetIsolate(),
v8::MicrotasksScope::kDoNotRunMicrotasks);
- if (!V8Call(v8::String::NewFromUtf8(GetIsolate(), s,
- v8::NewStringType::kNormal),
- source)) {
+ if (!v8::String::NewFromUtf8(GetIsolate(), s, v8::NewStringType::kNormal)
+ .ToLocal(&source)) {
ADD_FAILURE();
return v8::MaybeLocal<v8::Value>();
}
- if (!V8Call(v8::Script::Compile(GetScriptState()->GetContext(), source),
- script)) {
+ if (!v8::Script::Compile(GetScriptState()->GetContext(), source)
+ .ToLocal(&script)) {
ADD_FAILURE() << "Compilation fails";
return v8::MaybeLocal<v8::Value>();
}
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp ('k') | third_party/WebKit/Source/modules/nfc/NFC.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698