third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

index 3564c21d31dc671633140390734dc89fb720293e..ae58a62b72f2026b9982d2701071b732f2022cf2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

@@ -266,9 +266,9 @@ bool V0CustomElementConstructorBuilder::PrototypeIsValid(

}

v8::PropertyAttribute property_attribute;

- if (!V8Call(prototype_->GetPropertyAttributes(

- context, V8String(isolate, "constructor")),

- property_attribute) ||

+ if (!prototype_

+ ->GetPropertyAttributes(context, V8String(isolate, "constructor"))

+ .To(&property_attribute) ||

(property_attribute & v8::DontDelete)) {

V0CustomElementException::ThrowException(

V0CustomElementException::kConstructorPropertyNotConfigurable, type,