Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
index 4b6ed82998a6969d1aa0bdd792d188a8dce8ff24..10e321d43e9e6c939aeeaf718ea092f7e18bafb1 100644
--- a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
@@ -80,10 +80,10 @@ DictionaryIterator Dictionary::GetIterator(
!iterator_getter->IsFunction())
return nullptr;
v8::Local<v8::Value> iterator;
- if (!V8Call(V8ScriptRunner::CallFunction(
- v8::Local<v8::Function>::Cast(iterator_getter),
- execution_context, dictionary_object_, 0, nullptr, isolate_),
- iterator))
+ if (!V8ScriptRunner::CallFunction(
+ v8::Local<v8::Function>::Cast(iterator_getter), execution_context,
+ dictionary_object_, 0, nullptr, isolate_)
+ .ToLocal(&iterator))
return nullptr;
if (!iterator->IsObject())
return nullptr;
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698