third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp - Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp

Issue 2836093004: Remove V8Call and replace with v8::Maybe<T>::To and v8::MaybeLocal<T>::ToLocal. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp b/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp

index 12e7950fa25d11fe50c24a3ed7303b07ad427581..3f327bbc852b82602ae3431c3e6e01581cf17b78 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.cpp

@@ -30,10 +30,11 @@ v8::MaybeLocal<v8::Value> V8UnpackIteratorResult(ScriptState* script_state,

if (maybe_value.IsEmpty())

return maybe_value;

v8::Local<v8::Value> done_value;

- if (!V8Call(result->Get(script_state->GetContext(),

- V8String(script_state->GetIsolate(), "done")),

- done_value) ||

- !V8Call(done_value->BooleanValue(script_state->GetContext()), *done)) {

+ if (!result

+ ->Get(script_state->GetContext(),

+ V8String(script_state->GetIsolate(), "done"))

+ .ToLocal(&done_value) ||

+ !done_value->BooleanValue(script_state->GetContext()).To(done)) {

return v8::MaybeLocal<v8::Value>();

}

return maybe_value;