Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, David Black, dominickn+watch_chromium.org, skanuj+watch_chromium.org, asvitkine+watch_chromium.org, tburkard+watch_chromium.org, rogerm+autofillwatch_chromium.org, ajwong+watch_chromium.org, browser-components-watch_chromium.org, msramek+watch_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, loading-reviews+metrics_chromium.org, agrieve+watch_chromium.org, subresource-filter-reviews_chromium.org, markusheintz_, dimich+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, chili+watch_chromium.org, fgorski+watch_chromium.org, sebsg+autofillwatch_chromium.org, raymes+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, darin-cc_chromium.org, dfalcantara+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, Avi (use Gerrit), nasko+codewatch_chromium.org, creis+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mlamouri+watch-screen-orientation_chromium.org, jdonnelly+watch_chromium.org, rouslan+autofill_chromium.org, petewil+watch_chromium.org, dkrahn+watch_chromium.org, feature-media-reviews_chromium.org, lizeb+watch-custom-tabs_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, mlamouri+watch-permissions_chromium.org, gcasto+watchlist_chromium.org, dbeam+watch-settings_chromium.org, Jered, michaelpg+watch-options_chromium.org, romax+watch_chromium.org, mathp+autofillwatch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, csharrison+watch_chromium.org, dewittj+watch_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, pkotwicz+watch_chromium.org, samarth+watch_chromium.org, grt+watch_chromium.org, estade+watch_chromium.org, zpeng+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, kkhorimoto
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument Old name was presumable used to match was_within_same_page IPC, but IsSameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with WebKit (which has SameDocumentNavigationSource class) and Chrome for iOS, which uses SameDocument term. BUG=695189 TBR=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2716493004 Cr-Commit-Position: refs/heads/master@{#455106} Committed: https://chromium.googlesource.com/chromium/src/+/a11672fb4c998040224d7dc97e5bdc05d46a4145

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Rebased #

Patch Set 4 : Fixed compilation #

Patch Set 5 : Fixed Android compilation #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -187 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/PostMessageHandler.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabStateBrowserControlsVisibilityDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner.cc View 1 2 3 4 5 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/engagement/site_engagement_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_action_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_service.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/installable/installable_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/first_web_contents_profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/google_captcha_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/security_state_tab_helper.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_error_handler.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_navigation_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_metrics_recorder.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/content_autofill_driver.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/dom_distiller/content/browser/distillability_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/browser/web_contents_main_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/translate/content/browser/content_translate_driver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/zoom/zoom_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/web_contents_observer_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl_browsertest.cc View 1 2 16 chunks +18 lines, -17 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/session/media_session_impl.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/permissions/permission_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_content_origin_whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java View 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/navigation_handle.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/test_frame_navigation_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_navigation_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 57 (34 generated)
Eugene But (OOO till 7-30)
clamy@ I will add more people as reviewers if this looks good to you.
3 years, 10 months ago (2017-02-23 21:24:28 UTC) #7
clamy
Thanks for the cleanup! content/ lgtm.
3 years, 9 months ago (2017-02-27 15:19:28 UTC) #11
Eugene But (OOO till 7-30)
+jam@ for top level owners
3 years, 9 months ago (2017-02-27 16:21:13 UTC) #13
jam
what's more consistent in content and embedders of it? searching for samepage shows lots of ...
3 years, 9 months ago (2017-02-27 20:24:54 UTC) #14
Eugene But (OOO till 7-30)
On 2017/02/27 20:24:54, jam wrote: > what's more consistent in content and embedders of it? ...
3 years, 9 months ago (2017-02-27 22:59:43 UTC) #15
jam
On 2017/02/27 22:59:43, Eugene But wrote: > On 2017/02/27 20:24:54, jam wrote: > > what's ...
3 years, 9 months ago (2017-02-28 16:22:23 UTC) #16
Eugene But (OOO till 7-30)
On 2017/02/28 16:22:23, jam wrote: > On 2017/02/27 22:59:43, Eugene But wrote: > > On ...
3 years, 9 months ago (2017-02-28 16:49:29 UTC) #17
Charlie Reis
On 2017/02/28 16:49:29, Eugene But wrote: > On 2017/02/28 16:22:23, jam wrote: > > On ...
3 years, 9 months ago (2017-02-28 17:32:29 UTC) #19
jam
On 2017/02/28 17:32:29, Charlie Reis (slow) wrote: > On 2017/02/28 16:49:29, Eugene But wrote: > ...
3 years, 9 months ago (2017-03-01 15:33:45 UTC) #20
Eugene But (OOO till 7-30)
"document" is already an existing term described in HTML or whatever web spec. "SameDocument" is ...
3 years, 9 months ago (2017-03-01 16:36:49 UTC) #21
clamy
FWIW: I think InFrame is even more confusing. Technically, all main-frame navigations are in frame, ...
3 years, 9 months ago (2017-03-01 16:41:50 UTC) #22
nasko
On 2017/03/01 16:41:50, clamy wrote: > FWIW: I think InFrame is even more confusing. Technically, ...
3 years, 9 months ago (2017-03-01 17:47:12 UTC) #23
Eugene But (OOO till 7-30)
On 2017/03/01 17:47:12, nasko (slow) wrote: > On 2017/03/01 16:41:50, clamy wrote: > > FWIW: ...
3 years, 9 months ago (2017-03-02 22:56:46 UTC) #24
jam
On 2017/03/02 22:56:46, Eugene But wrote: > On 2017/03/01 17:47:12, nasko (slow) wrote: > > ...
3 years, 9 months ago (2017-03-03 16:45:05 UTC) #25
Eugene But (OOO till 7-30)
Thank you! I will send more CLs to rename remaining APIs.
3 years, 9 months ago (2017-03-03 19:58:05 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716493004/40001
3 years, 9 months ago (2017-03-03 19:58:40 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/378009)
3 years, 9 months ago (2017-03-03 20:07:28 UTC) #31
gone
drive by OWNERs lgtm for infobars/
3 years, 9 months ago (2017-03-03 20:08:50 UTC) #33
Eugene But (OOO till 7-30)
+ dbeam@ for chrome/browser/ui/webui/options
3 years, 9 months ago (2017-03-04 00:32:56 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716493004/100001
3 years, 9 months ago (2017-03-07 04:24:10 UTC) #50
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379107)
3 years, 9 months ago (2017-03-07 06:30:12 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716493004/100001
3 years, 9 months ago (2017-03-07 15:24:33 UTC) #54
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:14:45 UTC) #57
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a11672fb4c998040224d7dc97e5b...

Powered by Google App Engine
This is Rietveld 408576698