components/translate/content/browser/content_translate_driver.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/content_translate_driver.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/content/browser/content_translate_driver.cc

diff --git a/components/translate/content/browser/content_translate_driver.cc b/components/translate/content/browser/content_translate_driver.cc

index 9eb5694f3a402138909c75902ff0f64a9bd66236..0daeb0b4e4bbb1c3d8fc3fbfaee4c1f3aba1306d 100644

--- a/components/translate/content/browser/content_translate_driver.cc

+++ b/components/translate/content/browser/content_translate_driver.cc

@@ -220,9 +220,9 @@ void ContentTranslateDriver::DidFinishNavigation(

// Let the LanguageState clear its state.

const bool reload =

navigation_handle->GetReloadType() != content::ReloadType::NONE ||

- navigation_handle->IsSamePage();

+ navigation_handle->IsSameDocument();

translate_manager_->GetLanguageState().DidNavigate(

- navigation_handle->IsSamePage(), navigation_handle->IsInMainFrame(),

+ navigation_handle->IsSameDocument(), navigation_handle->IsInMainFrame(),

reload);

}