chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

index b7193081807ff80f6c27fa622392c7b5ffa33a5b..33224cd3ee44b5ef5fe234a5039dd0d2f3b0c5cc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

@@ -473,13 +473,13 @@ public class WebappActivity extends FullScreenActivity {

@Override

public void onDidStartNavigation(Tab tab, String url, boolean isInMainFrame,

- boolean isSamePage, boolean isErrorPage) {

- if (isInMainFrame && !isSamePage) updateUrlBar();

+ boolean isSameDocument, boolean isErrorPage) {

+ if (isInMainFrame && !isSameDocument) updateUrlBar();

}

@Override

public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,

- boolean isErrorPage, boolean hasCommitted, boolean isSamePage,

+ boolean isErrorPage, boolean hasCommitted, boolean isSameDocument,

boolean isFragmentNavigation, Integer pageTransition, int errorCode,

int httpStatusCode) {

if (hasCommitted && isInMainFrame) updateUrlBar();