components/guest_view/browser/guest_view_base.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/guest_view/browser/guest_view_base.cc

diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc

index 606a47060b430eb6e808386349dd97f21c3fe211..13a8da51f1f0a9ed545fadbf1a9b4969f656fef3 100644

--- a/components/guest_view/browser/guest_view_base.cc

+++ b/components/guest_view/browser/guest_view_base.cc

@@ -75,7 +75,7 @@ class GuestViewBase::OwnerContentsObserver : public WebContentsObserver {

// If the embedder navigates to a different page then destroy the guest.

if (!navigation_handle->IsInMainFrame() ||

!navigation_handle->HasCommitted() ||

- navigation_handle->IsSamePage()) {

+ navigation_handle->IsSameDocument()) {

return;

}