Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
index 90ef18aacc06450c48d23d89f4a88256bf19147f..b89b19a4f13207fc469799e2e2be53ffacddd2f3 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
@@ -254,7 +254,7 @@ void WebNavigationTabObserver::RenderFrameHostChanged(
void WebNavigationTabObserver::DidStartNavigation(
content::NavigationHandle* navigation_handle) {
- if (navigation_handle->IsSamePage() ||
+ if (navigation_handle->IsSameDocument() ||
!FrameNavigationState::IsValidUrl(navigation_handle->GetURL())) {
return;
}
@@ -422,7 +422,7 @@ void WebNavigationTabObserver::HandleCommit(
navigation_state_.StartTrackingDocumentLoad(
navigation_handle->GetRenderFrameHost(), navigation_handle->GetURL(),
- navigation_handle->IsSamePage(),
+ navigation_handle->IsSameDocument(),
false); // is_error_page
events::HistogramValue histogram_value = events::UNKNOWN;
@@ -430,7 +430,7 @@ void WebNavigationTabObserver::HandleCommit(
if (is_reference_fragment_navigation) {
histogram_value = events::WEB_NAVIGATION_ON_REFERENCE_FRAGMENT_UPDATED;
event_name = web_navigation::OnReferenceFragmentUpdated::kEventName;
- } else if (navigation_handle->IsSamePage()) {
+ } else if (navigation_handle->IsSameDocument()) {
histogram_value = events::WEB_NAVIGATION_ON_HISTORY_STATE_UPDATED;
event_name = web_navigation::OnHistoryStateUpdated::kEventName;
} else {
@@ -445,7 +445,7 @@ void WebNavigationTabObserver::HandleError(
if (navigation_handle->HasCommitted()) {
navigation_state_.StartTrackingDocumentLoad(
navigation_handle->GetRenderFrameHost(), navigation_handle->GetURL(),
- navigation_handle->IsSamePage(),
+ navigation_handle->IsSameDocument(),
true); // is_error_page
}

Powered by Google App Engine
This is Rietveld 408576698