Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/navigation_handle.h ('k') | content/public/test/test_frame_navigation_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index fe55fada142aab623c8a9853e1f97667c6f24045..2f13338c883f5783868db6aaf8a4ae19d62be2fa 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -140,9 +140,9 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// Note that this is fired by navigations in any frame of the WebContents,
// not just the main frame.
//
- // Note that this is fired by same-page navigations, such as fragment
+ // Note that this is fired by same-document navigations, such as fragment
// navigations or pushState/replaceState, which will not result in a document
- // change. To filter these out, use NavigationHandle::IsSamePage.
+ // change. To filter these out, use NavigationHandle::IsSameDocument.
//
// Note that more than one navigation can be ongoing in the same frame at the
// same time (including the main frame). Each will get its own
@@ -179,9 +179,9 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// and related methods to listen for continued events from this
// RenderFrameHost.
//
- // Note that this is fired by same-page navigations, such as fragment
+ // Note that this is fired by same-document navigations, such as fragment
// navigations or pushState/replaceState, which will not result in a document
- // change. To filter these out, use NavigationHandle::IsSamePage.
+ // change. To filter these out, use NavigationHandle::IsSameDocument.
//
// Note that |navigation_handle| will be destroyed at the end of this call,
// so do not keep a reference to it afterward.
« no previous file with comments | « content/public/browser/navigation_handle.h ('k') | content/public/test/test_frame_navigation_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698