components/autofill/content/browser/content_autofill_driver.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/content_autofill_driver.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/browser/content_autofill_driver.cc

diff --git a/components/autofill/content/browser/content_autofill_driver.cc b/components/autofill/content/browser/content_autofill_driver.cc

index 710a1e74c9a0c680f9312bde85d60d7d3ecb2dfb..a0fed92c8641b8815a7067f8ca77037980b48a2c 100644

--- a/components/autofill/content/browser/content_autofill_driver.cc

+++ b/components/autofill/content/browser/content_autofill_driver.cc

@@ -241,8 +241,10 @@ void ContentAutofillDriver::SetDataList(

void ContentAutofillDriver::DidNavigateFrame(

content::NavigationHandle* navigation_handle) {

- if (navigation_handle->IsInMainFrame() && !navigation_handle->IsSamePage())

+ if (navigation_handle->IsInMainFrame() &&

+ !navigation_handle->IsSameDocument()) {

autofill_manager_->Reset();

+ }

}

void ContentAutofillDriver::SetAutofillManager(