Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.tab; 5 package org.chromium.chrome.browser.tab;
6 6
7 import android.graphics.Bitmap; 7 import android.graphics.Bitmap;
8 import android.support.annotation.Nullable; 8 import android.support.annotation.Nullable;
9 import android.view.ContextMenu; 9 import android.view.ContextMenu;
10 10
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 * @param failingUrl The url that was loading when the error occurred . 201 * @param failingUrl The url that was loading when the error occurred .
202 */ 202 */
203 void onDidFailLoad( 203 void onDidFailLoad(
204 Tab tab, boolean isMainFrame, int errorCode, String description, Str ing failingUrl); 204 Tab tab, boolean isMainFrame, int errorCode, String description, Str ing failingUrl);
205 205
206 /** 206 /**
207 * Called when a navigation is started in the WebContents. 207 * Called when a navigation is started in the WebContents.
208 * @param tab The notifying {@link Tab}. 208 * @param tab The notifying {@link Tab}.
209 * @param url The validated URL for the loading page. 209 * @param url The validated URL for the loading page.
210 * @param isInMainFrame Whether the navigation is for the main frame. 210 * @param isInMainFrame Whether the navigation is for the main frame.
211 * @param isSamePage Whether the main frame navigation did not cause changes to the 211 * @param isSameDocument Whether the main frame navigation did not cause cha nges to the
212 * document (for example scrolling to a named anchor or Po pState). 212 * document (for example scrolling to a named anchor or Po pState).
213 * @param isErrorPage Whether the navigation shows an error page. 213 * @param isErrorPage Whether the navigation shows an error page.
214 */ 214 */
215 public void onDidStartNavigation( 215 public void onDidStartNavigation(Tab tab, String url, boolean isInMainFrame,
216 Tab tab, String url, boolean isInMainFrame, boolean isSamePage, bool ean isErrorPage); 216 boolean isSameDocument, boolean isErrorPage);
217 217
218 /** 218 /**
219 * Called when a navigation is finished i.e. committed, aborted or replaced by a new one. 219 * Called when a navigation is finished i.e. committed, aborted or replaced by a new one.
220 * @param tab The notifying {@link Tab}. 220 * @param tab The notifying {@link Tab}.
221 * @param url The validated URL for the loading page. 221 * @param url The validated URL for the loading page.
222 * @param isInMainFrame Whether the navigation is for the main frame. 222 * @param isInMainFrame Whether the navigation is for the main frame.
223 * @param isErrorPage Whether the navigation shows an error page. 223 * @param isErrorPage Whether the navigation shows an error page.
224 * @param hasCommitted Whether the navigation has committed. This returns tr ue for either 224 * @param hasCommitted Whether the navigation has committed. This returns tr ue for either
225 * successful commits or error pages that replace the pr evious page 225 * successful commits or error pages that replace the pr evious page
226 * (distinguished by |isErrorPage|), and false for error s that leave the 226 * (distinguished by |isErrorPage|), and false for error s that leave the
227 * user on the previous page. 227 * user on the previous page.
228 * @param isSamePage Whether the main frame navigation did not cause changes to the 228 * @param isSameDocument Whether the main frame navigation did not cause cha nges to the
229 * document (for example scrolling to a named anchor or Po pState). 229 * document (for example scrolling to a named anchor or Po pState).
230 * @param isFragmentNavigation Whether the main frame navigation did not cau se changes 230 * @param isFragmentNavigation Whether the main frame navigation did not cau se changes
231 * to the document (for example scrolling to a n amed anchor 231 * to the document (for example scrolling to a n amed anchor
232 * or PopState). 232 * or PopState).
233 * @param pageTransition The page transition type associated with this navig ation. 233 * @param pageTransition The page transition type associated with this navig ation.
234 * @param errorCode The net error code if an error occurred prior to commit, otherwise net::OK. 234 * @param errorCode The net error code if an error occurred prior to commit, otherwise net::OK.
235 * @param httpStatusCode The HTTP status code of the navigation. 235 * @param httpStatusCode The HTTP status code of the navigation.
236 */ 236 */
237 public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame , 237 public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame ,
238 boolean isErrorPage, boolean hasCommitted, boolean isSamePage, 238 boolean isErrorPage, boolean hasCommitted, boolean isSameDocument,
239 boolean isFragmentNavigation, @Nullable Integer pageTransition, int errorCode, 239 boolean isFragmentNavigation, @Nullable Integer pageTransition, int errorCode,
240 int httpStatusCode); 240 int httpStatusCode);
241 241
242 /** 242 /**
243 * Called when the page has painted something non-empty. 243 * Called when the page has painted something non-empty.
244 * @param tab The notifying {@link Tab}. 244 * @param tab The notifying {@link Tab}.
245 */ 245 */
246 public void didFirstVisuallyNonEmptyPaint(Tab tab); 246 public void didFirstVisuallyNonEmptyPaint(Tab tab);
247 247
248 /** 248 /**
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 public void webContentsCreated(Tab tab, WebContents sourceWebContents, 284 public void webContentsCreated(Tab tab, WebContents sourceWebContents,
285 long openerRenderProcessId, long openerRenderFrameId, String frameNa me, 285 long openerRenderProcessId, long openerRenderFrameId, String frameNa me,
286 String targetUrl, WebContents newWebContents); 286 String targetUrl, WebContents newWebContents);
287 287
288 /** 288 /**
289 * Called when the tab reparenting process has finished. 289 * Called when the tab reparenting process has finished.
290 * @param tab The notifying {@link Tab}. 290 * @param tab The notifying {@link Tab}.
291 */ 291 */
292 public void onReparentingFinished(Tab tab); 292 public void onReparentingFinished(Tab tab);
293 } 293 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698