Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index 95f076d299e9f0d282becec36ebc254eb0bb1645..1400bbf9d73deaba35d08e091267c5654d7b6ca7 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -246,8 +246,10 @@ void SearchTabHelper::DidStartNavigation(
if (!content::IsBrowserSideNavigationEnabled())
return;
- if (!navigation_handle->IsInMainFrame() || navigation_handle->IsSamePage())
+ if (!navigation_handle->IsInMainFrame() ||
+ navigation_handle->IsSameDocument()) {
return;
+ }
if (search::IsNTPURL(navigation_handle->GetURL(), profile())) {
// Set the title on any pending entry corresponding to the NTP. This
@@ -263,7 +265,8 @@ void SearchTabHelper::DidStartNavigation(
void SearchTabHelper::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
- if (!navigation_handle->IsInMainFrame() || navigation_handle->IsSamePage())
+ if (!navigation_handle->IsInMainFrame() ||
+ navigation_handle->IsSameDocument())
return;
if (IsCacheableNTP(web_contents_)) {
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | chrome/browser/ui/webui/extensions/extensions_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698