chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_tab_permission_granter.cc ('k') | chrome/browser/extensions/api/messaging/extension_message_port.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc

diff --git a/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc b/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc

index 2f52275a2f0b77ded6fbbed31ec0b8d0352a4758..d69a933eaf52974edb7d0d2c91e80118bb5340da 100644

--- a/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc

+++ b/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc

@@ -99,7 +99,7 @@ DeclarativeContentCssConditionTracker::PerWebContentsTracker::

void DeclarativeContentCssConditionTracker::PerWebContentsTracker::

OnWebContentsNavigation(content::NavigationHandle* navigation_handle) {

- if (navigation_handle->IsSamePage()) {

+ if (navigation_handle->IsSameDocument()) {

// Within-page navigations don't change the set of elements that

// exist, and we only support filtering on the top-level URL, so

// this can't change which rules match.