Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 4d368eb27b6e1c9e7a45b7b8c48b744624f1f5e0..88cf70c7ed8d64a9a7ac8f921ae768ac9655ab33 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -3379,10 +3379,10 @@ RenderFrameHostImpl::TakeNavigationHandleForCommit(
if (params.was_within_same_page) {
if (IsBrowserSideNavigationEnabled()) {
// When browser-side navigation is enabled, a NavigationHandle is created
- // for browser-initiated same-page navigation. Try to take it if it's
+ // for browser-initiated same-document navigation. Try to take it if it's
// still available and matches the current navigation.
if (is_browser_initiated && navigation_handle_ &&
- navigation_handle_->IsSamePage() &&
+ navigation_handle_->IsSameDocument() &&
navigation_handle_->GetURL() == params.url) {
return std::move(navigation_handle_);
}
@@ -3390,7 +3390,7 @@ RenderFrameHostImpl::TakeNavigationHandleForCommit(
// When browser-side navigation is disabled, there is never any existing
// NavigationHandle to use for the navigation. We don't ever expect
// navigation_handle_ to match.
- DCHECK(!navigation_handle_ || !navigation_handle_->IsSamePage());
+ DCHECK(!navigation_handle_ || !navigation_handle_->IsSameDocument());
}
// No existing NavigationHandle has been found. Create a new one, but don't
// reset any NavigationHandle tracking an ongoing navigation, since this may
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/media/session/media_session_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698