content/browser/frame_host/navigation_controller_impl_browsertest.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/bluetooth/web_bluetooth_service_impl.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

index 89ee3b1697135eb64c1cb1608784979bcd92f632..014e75eee1888ed8ca6b5e6dbdff03e4133c85cb 100644

--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

@@ -644,7 +644,7 @@ class FrameNavigateParamsCapturer : public WebContentsObserver {

navigation_types_.push_back(

static_cast<NavigationHandleImpl*>(navigation_handle)

->navigation_type());

- is_in_pages_.push_back(navigation_handle->IsSamePage());

+ is_in_pages_.push_back(navigation_handle->IsSameDocument());

if (!navigations_remaining_ &&

(!web_contents()->IsLoading() || !wait_for_load_))

message_loop_runner_->Quit();

@@ -6666,7 +6666,7 @@ class NavigationHandleCommitObserver : public WebContentsObserver {

if (handle->GetURL() != url_)

return;

has_committed_ = true;

- was_same_page_ = handle->IsSamePage();

+ was_same_page_ = handle->IsSameDocument();

was_renderer_initiated_ = handle->IsRendererInitiated();

}