components/dom_distiller/content/browser/dom_distiller_viewer_source.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/browser/dom_distiller_viewer_source.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/browser/distillability_driver.cc ('k') | components/dom_distiller/content/browser/web_contents_main_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/browser/dom_distiller_viewer_source.cc

diff --git a/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc b/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc

index aa6e2a89b014a6d90594078ba89a2c5d95b130b3..061bf0cc2fda7c07049100bc5a0f3a1555228583 100644

--- a/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc

+++ b/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc

@@ -138,7 +138,7 @@ void DomDistillerViewerSource::RequestViewerHandle::DidFinishNavigation(

bool expected_main_view_request =

navigation.SchemeIs(expected_scheme_.c_str()) &&

expected_request_path_ == navigation.query();

- if (navigation_handle->IsSamePage() || expected_main_view_request) {

+ if (navigation_handle->IsSameDocument() || expected_main_view_request) {

// In-page navigations, as well as the main view request can be ignored.

if (expected_main_view_request) {

content::RenderFrameHost* render_frame_host =