chrome/browser/engagement/site_engagement_helper.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_helper.cc

diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc

index 166b8f398eaff8c27b285a9622f4fe8226aa066b..3c7b4a949d4870a15e5653a2857540e11b2e7752 100644

--- a/chrome/browser/engagement/site_engagement_helper.cc

+++ b/chrome/browser/engagement/site_engagement_helper.cc

@@ -235,7 +235,7 @@ void SiteEngagementService::Helper::DidFinishNavigation(

content::NavigationHandle* handle) {

// Ignore uncommitted, non main-frame, same page, or error page navigations.

if (!handle->HasCommitted() || !handle->IsInMainFrame() ||

- handle->IsSamePage() || handle->IsErrorPage()) {

+ handle->IsSameDocument() || handle->IsErrorPage()) {

return;

}