chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

index 6c250dc4004ec890aaed8f5e003004c0981a8647..4165569f259dcdab1ce1c86303bfa55917a05c82 100644

--- a/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

+++ b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

@@ -172,8 +172,8 @@ void SaveCardBubbleControllerImpl::DidFinishNavigation(

if (save_card_callback_.is_null())

return;

- // Don't react to in-page (fragment) navigations.

- if (navigation_handle->IsSamePage())

+ // Don't react to same-document (fragment) navigations.

+ if (navigation_handle->IsSameDocument())

return;

// Don't do anything if a navigation occurs before a user could reasonably