Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index bfc55e3c0451feadcd033ab282e089529ce308f9..05d4a4bac27cd83ec1cfb6cc2d1cf18f8d8e1718 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -229,15 +229,17 @@ void BackgroundLoaderOffliner::DidFinishNavigation(
}
}
- // If the page is not the same, invalidate any pending save tasks.
+ // If the document is not the same, invalidate any pending save tasks.
//
// Downloads or 204/205 response codes do not commit (no new navigation)
- // Same-Page (committed) navigations are:
+ // Same-Document (committed) navigations are:
// - reference fragment navigations
// - pushState/replaceState
- // - same page history navigation
- if (navigation_handle->HasCommitted() && !navigation_handle->IsSamePage())
+ // - same document history navigation
+ if (navigation_handle->HasCommitted() &&
+ !navigation_handle->IsSameDocument()) {
weak_ptr_factory_.InvalidateWeakPtrs();
+ }
}
void BackgroundLoaderOffliner::SetPageDelayForTest(long delay_ms) {

Powered by Google App Engine
This is Rietveld 408576698