chrome/browser/page_load_metrics/observers/google_captcha_observer.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

index 2a50feb3c32e913ffe11663134755da917044e44..abc00e4f9dd8ffe38d067505e10353d8485cbc5e 100644

--- a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

@@ -46,8 +46,8 @@ GoogleCaptchaObserver::GoogleCaptchaObserver() {}

page_load_metrics::PageLoadMetricsObserver::ObservePolicy

GoogleCaptchaObserver::OnCommit(content::NavigationHandle* navigation_handle) {

- if (!navigation_handle->IsSamePage()

- && IsGoogleCaptcha(navigation_handle->GetURL())) {

+ if (!navigation_handle->IsSameDocument() &&

+ IsGoogleCaptcha(navigation_handle->GetURL())) {

RecordGoogleCaptchaEvent(GOOGLE_CAPTCHA_SHOWN);

}

return CONTINUE_OBSERVING;