components/password_manager/content/browser/content_password_manager_driver.cc - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/browser/guest_view_base.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc

index ebf591eba28d1eafbd05664bb1316650c43502fa..4058abb1f43ec22ef2cac7b8210b5b2cc36ea8b5 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver.cc

@@ -229,7 +229,8 @@ void ContentPasswordManagerDriver::

void ContentPasswordManagerDriver::DidNavigateFrame(

content::NavigationHandle* navigation_handle) {

// Clear page specific data after main frame navigation.

- if (navigation_handle->IsInMainFrame() && !navigation_handle->IsSamePage()) {

+ if (navigation_handle->IsInMainFrame() &&

+ !navigation_handle->IsSameDocument()) {

GetPasswordManager()->DidNavigateMainFrame();

GetPasswordAutofillManager()->DidNavigateMainFrame();

}