chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java - Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

index b007279bbb935be5f4926c028274e2af2e513570..4e807a63533ec9d4df49b233baf42f2e2365a4d5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

@@ -86,12 +86,12 @@ public class EmptyTabObserver implements TabObserver {

Tab tab, boolean isMainFrame, int errorCode, String description, String failingUrl) {}

@Override

- public void onDidStartNavigation(

- Tab tab, String url, boolean isInMainFrame, boolean isSamePage, boolean isErrorPage) {}

+ public void onDidStartNavigation(Tab tab, String url, boolean isInMainFrame,

+ boolean isSameDocument, boolean isErrorPage) {}

@Override

public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,

- boolean isErrorPage, boolean hasCommitted, boolean isSamePage,

+ boolean isErrorPage, boolean hasCommitted, boolean isSameDocument,

boolean isFragmentNavigation, Integer pageTransition, int errorCode,

int httpStatusCode) {}