Remove page IDs from three WebContentsObserver APIs that don't need it.

Remove page IDs from three WebContentsObserver APIs that don't need it.

Page IDs are not safe to use on their own, without knowing which SiteInstance
they correspond to.

BUG=369661
TEST=Dead code, no behavior change.
TBR=jam
TBR=mkosiba

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268312

[Charlie Reis, 2014-05-02 22:33:21]

John, can you take a look?  I'll fill in other owners as needed after that.

https://codereview.chromium.org/266053003/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (left):

https://codereview.chromium.org/266053003/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:3465: Details<int>(&page_id));
I checked on code search and couldn't find anyone using this value.

[Charlie Reis, 2014-05-03 00:48:49]

I'll go ahead and add owners now, since this is just dead code removal:

mkosiba: Can you look at all the files with android in the name?  I think I
fixed the build errors, but I may have missed something.

nasko: Can you look at view_messages.h?

benwells: Can you look at app_window.{h,cc}?

[jabdelmalek, 2014-05-03 00:51:20]

lgtm

[benwells, 2014-05-05 01:08:01]

lgtm

[nasko, 2014-05-05 14:00:07]

IPC LGTM

[Charlie Reis, 2014-05-05 18:38:05]

Thanks!  I think I've fixed compile on all platforms at this point, and I had to
do a fairly large rebase since Avi moved DocumentOnLoadCompleted to RenderFrame
on Friday.

jam: Can you take a look at chrome/browser/ui/metro_pin_tab_helper_win.h?  I
missed it before.

nasko: Can you do a pass over the render{view,frame} classes and
frame_messages.h to make sure I updated it correctly after Avi's CL?

mkosiba: Can you review the Android stuff?

[nasko, 2014-05-05 20:27:26]

LGTM

[Charlie Reis, 2014-05-05 21:07:40]

I'll go ahead with this as TBR for jam/mkosiba, since John has already seen the
basic idea and it's all just dead code removal.  @mkosiba, feel free to ping me
if you see any issues after the fact.

[Charlie Reis, 2014-05-05 21:07:47]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2014-05-05 21:08:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/creis@chromium.org/266053003/80001

[commit-bot: I haz the power, 2014-05-05 23:24:36]

Change committed as 268312

[mkosiba (inactive), 2014-05-06 09:35:09]

android bits LGTM. Sorry for the late reply, we had a day off here in the UK.