Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: content/public/browser/notification_types.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with Avi's change Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NOTIFICATION_TYPES_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NOTIFICATION_TYPES_H_
6 #define CONTENT_PUBLIC_BROWSER_NOTIFICATION_TYPES_H_ 6 #define CONTENT_PUBLIC_BROWSER_NOTIFICATION_TYPES_H_
7 7
8 // This file describes various types used to describe and filter notifications 8 // This file describes various types used to describe and filter notifications
9 // that pass through the NotificationService. 9 // that pass through the NotificationService.
10 // 10 //
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 // 65 //
66 // This will NOT be sent on navigation, interested parties should also 66 // This will NOT be sent on navigation, interested parties should also
67 // listen for NAV_ENTRY_COMMITTED to handle that case. This will be 67 // listen for NAV_ENTRY_COMMITTED to handle that case. This will be
68 // sent when the entry is updated outside of navigation (like when a new 68 // sent when the entry is updated outside of navigation (like when a new
69 // title comes). 69 // title comes).
70 NOTIFICATION_NAV_ENTRY_CHANGED, 70 NOTIFICATION_NAV_ENTRY_CHANGED,
71 71
72 // Other load-related (not from NavigationController) ---------------------- 72 // Other load-related (not from NavigationController) ----------------------
73 73
74 // Corresponds to ViewHostMsg_DocumentOnLoadCompletedInMainFrame. The source 74 // Corresponds to ViewHostMsg_DocumentOnLoadCompletedInMainFrame. The source
75 // is the WebContents and the details the page_id. 75 // is the WebContents.
76 // DEPRECATED: Use WebContentsObserver::DocumentOnLoadCompletedInMainFrame() 76 // DEPRECATED: Use WebContentsObserver::DocumentOnLoadCompletedInMainFrame()
77 NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME, 77 NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
78 78
79 // A content load is starting. The source will be a 79 // A content load is starting. The source will be a
80 // Source<NavigationController> corresponding to the tab in which the load 80 // Source<NavigationController> corresponding to the tab in which the load
81 // is occurring. No details are expected for this notification. 81 // is occurring. No details are expected for this notification.
82 // DEPRECATED: Use WebContentsObserver::DidStartLoading() 82 // DEPRECATED: Use WebContentsObserver::DidStartLoading()
83 NOTIFICATION_LOAD_START, 83 NOTIFICATION_LOAD_START,
84 84
85 // A content load has stopped. The source will be a 85 // A content load has stopped. The source will be a
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 // the RenderViewHost, and the details is a DomOperationNotificationDetails. 214 // the RenderViewHost, and the details is a DomOperationNotificationDetails.
215 NOTIFICATION_DOM_OPERATION_RESPONSE, 215 NOTIFICATION_DOM_OPERATION_RESPONSE,
216 216
217 // Custom notifications used by the embedder should start from here. 217 // Custom notifications used by the embedder should start from here.
218 NOTIFICATION_CONTENT_END, 218 NOTIFICATION_CONTENT_END,
219 }; 219 };
220 220
221 } // namespace content 221 } // namespace content
222 222
223 #endif // CONTENT_PUBLIC_BROWSER_NOTIFICATION_TYPES_H_ 223 #endif // CONTENT_PUBLIC_BROWSER_NOTIFICATION_TYPES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698