content/browser/android/web_contents_observer_android.h - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_android.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc ('k') | content/browser/android/web_contents_observer_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_android.h

diff --git a/content/browser/android/web_contents_observer_android.h b/content/browser/android/web_contents_observer_android.h

index 6ff1093d996b972f5e70e22a5c00444ec0828aa5..0a4f874b311743e4dcaf33645e6a0cc23c1d42c0 100644

--- a/content/browser/android/web_contents_observer_android.h

+++ b/content/browser/android/web_contents_observer_android.h

@@ -54,7 +54,7 @@ class WebContentsObserverAndroid : public WebContentsObserver {

const FrameNavigateParams& params) OVERRIDE;

virtual void DidNavigateAnyFrame(const LoadCommittedDetails& details,

const FrameNavigateParams& params) OVERRIDE;

- virtual void DidFirstVisuallyNonEmptyPaint(int32 page_id) OVERRIDE;

+ virtual void DidFirstVisuallyNonEmptyPaint() OVERRIDE;

virtual void DidStartProvisionalLoadForFrame(

int64 frame_id,

int64 parent_frame_id,