chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

index e40885118e1d5d95cd33954587644b1cd60f1ede..a13cc50353da1a6c14aad0e736fc96d27ca6ae06 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

@@ -47,7 +47,7 @@ class ContentsObserver : public WebContentsObserver {

loaded_ = true;

}

- virtual void DidUpdateFaviconURL(int32 page_id,

+ virtual void DidUpdateFaviconURL(

const std::vector<content::FaviconURL>& candidates) OVERRIDE {

if (!candidates.empty())

got_favicons_ = true;

« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/browser/ui/metro_pin_tab_helper_win.h » ('j') | no next file with comments »