android_webview/browser/icon_helper.h - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/icon_helper.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/icon_helper.h

diff --git a/android_webview/browser/icon_helper.h b/android_webview/browser/icon_helper.h

index 13caefe1167943777299340c4063de58c959f969..f325450ff2fd9ab48b9bb4d2cead6628f387ffea 100644

--- a/android_webview/browser/icon_helper.h

+++ b/android_webview/browser/icon_helper.h

@@ -42,7 +42,7 @@ class IconHelper : public content::WebContentsObserver {

void SetListener(Listener* listener);

// From WebContentsObserver

- virtual void DidUpdateFaviconURL(int32 page_id,

+ virtual void DidUpdateFaviconURL(

const std::vector<content::FaviconURL>& candidates) OVERRIDE;

virtual void DidStartNavigationToPendingEntry(

const GURL& url,

« no previous file with comments | « no previous file | android_webview/browser/icon_helper.cc » ('j') | no next file with comments »