content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/web_contents/aura/overscroll_navigation_overlay.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index c3ea51910676c786dad6619e184bac98cf777cd6..e71ee014c02294eeb866581f59abc3b1ca2ef834 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -174,7 +174,6 @@ class PluginFaviconMessageObserver : public WebContentsObserver {

}

virtual void DidUpdateFaviconURL(

- int32 page_id,

const std::vector<FaviconURL>& candidates) OVERRIDE {

favicon_received_ = true;

}

@@ -399,7 +398,7 @@ TEST_F(RenderFrameHostManagerTest, FilterMessagesWhileSwappedOut) {

PluginFaviconMessageObserver observer(contents());

EXPECT_TRUE(ntp_rvh->OnMessageReceived(

ViewHostMsg_UpdateFaviconURL(

- rvh()->GetRoutingID(), 0, icons)));

+ rvh()->GetRoutingID(), icons)));

EXPECT_TRUE(observer.favicon_received());

}

// Create one more view in the same SiteInstance where ntp_rvh

@@ -422,7 +421,7 @@ TEST_F(RenderFrameHostManagerTest, FilterMessagesWhileSwappedOut) {

PluginFaviconMessageObserver observer(contents());

EXPECT_TRUE(

dest_rvh->OnMessageReceived(

- ViewHostMsg_UpdateFaviconURL(rvh()->GetRoutingID(), 101, icons)));

+ ViewHostMsg_UpdateFaviconURL(rvh()->GetRoutingID(), icons)));

EXPECT_TRUE(observer.favicon_received());

}

@@ -433,7 +432,7 @@ TEST_F(RenderFrameHostManagerTest, FilterMessagesWhileSwappedOut) {

PluginFaviconMessageObserver observer(contents());

EXPECT_TRUE(

ntp_rvh->OnMessageReceived(

- ViewHostMsg_UpdateFaviconURL(rvh()->GetRoutingID(), 101, icons)));

+ ViewHostMsg_UpdateFaviconURL(rvh()->GetRoutingID(), icons)));

EXPECT_FALSE(observer.favicon_received());

}