content/shell/browser/shell_devtools_frontend.h - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_frontend.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell_devtools_frontend.h

diff --git a/content/shell/browser/shell_devtools_frontend.h b/content/shell/browser/shell_devtools_frontend.h

index 6244380fc9a370c7ab970a6883164a58c2c8f753..8aac26aaec73364960b1c5ee711bfa113cb6d56d 100644

--- a/content/shell/browser/shell_devtools_frontend.h

+++ b/content/shell/browser/shell_devtools_frontend.h

@@ -43,7 +43,7 @@ class ShellDevToolsFrontend : public WebContentsObserver,

// WebContentsObserver overrides

virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;

- virtual void DocumentOnLoadCompletedInMainFrame(int32 page_id) OVERRIDE;

+ virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE;

virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;

// DevToolsFrontendHostDelegate implementation

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »