content/browser/web_contents/aura/overscroll_navigation_overlay.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/aura/overscroll_navigation_overlay.h ('k') | content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/aura/overscroll_navigation_overlay.cc

diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

index 28ae712cb127e9eb5943a66f87143c26ee08edae..1a17d9056ac6b4976259fc5013f0342564766d16 100644

--- a/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

@@ -301,8 +301,7 @@ void OverscrollNavigationOverlay::OnWindowSliderDestroyed() {

}

-void OverscrollNavigationOverlay::DocumentOnLoadCompletedInMainFrame(

- int32 page_id) {

+void OverscrollNavigationOverlay::DocumentOnLoadCompletedInMainFrame() {

// Use the last committed entry rather than the active one, in case a

// pending entry has been created.

int committed_entry_id =

@@ -314,7 +313,7 @@ void OverscrollNavigationOverlay::DocumentOnLoadCompletedInMainFrame(

}

-void OverscrollNavigationOverlay::DidFirstVisuallyNonEmptyPaint(int32 page_id) {

+void OverscrollNavigationOverlay::DidFirstVisuallyNonEmptyPaint() {

int visible_entry_id =

web_contents_->GetController().GetVisibleEntry()->GetUniqueID();

if (visible_entry_id == pending_entry_id_ || !pending_entry_id_) {